Skip to content

Configure file stash sync for Zoho CRM components #17267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 30, 2025
Merged

Configure file stash sync for Zoho CRM components #17267

merged 5 commits into from
Jun 30, 2025

Conversation

@js07
Copy link
Collaborator

@js07 js07 commented Jun 24, 2025 •
edited
Loading

WHY

Adding dir props to the Zoho CRM Download Attachment and Upload Attachment actions indicates that a stash ID should be passed when running these actions via the Connect API. This allows files written to the ephemeral /tmp directory in one action to be read by another, separately executed action since both can sync /tmp with the same File Stash directory.

Additional context: https://pipedream.com/docs/connect/components/files/

Summary by CodeRabbit

  • New Features

    • Added optional support for syncing a directory when downloading or uploading attachments, allowing files to persist or be accessed beyond the default temporary directory.

  • Chores

    • Updated action and package versions to reflect the latest changes.

js07 added 3 commits June 24, 2025 17:58
@js07
Add dir props to Zoho CRM components for File Stash sync
a7d0169 
Add dir props to the Zoho CRM Download Attachment and Upload Attachment
actions to indicate that a stash ID should be passed when running these
actions via the Connect API. This allows files written to the ephemeral
/tmp directory in one action to be read by another, separately executed
action since both can sync /tmp with the same File Stash directory.
@js07
bump Zoho CRM package version
278f543
@js07
update pnpm-lock.yaml
37ed507
@vercel
Copy link

vercel bot commented Jun 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2025 4:10pm
pipedream-docs ⬜️ Ignored (Inspect) Jun 26, 2025 4:10pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Jun 26, 2025 4:10pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 24, 2025 •
edited
Loading

Walkthrough

The changes introduce a new optional syncDir property to both the download and upload attachment actions in the Zoho CRM component, enabling directory synchronization for file persistence and access. The version numbers for these actions and the overall package were incremented to reflect these updates.

Changes

File(s) Change Summary
components/zoho_crm/actions/download-attachment/download-attachment.mjs Added optional syncDir prop (writable, sync-enabled directory), updated version, improved file path logic.
components/zoho_crm/actions/upload-attachment/upload-attachment.mjs Added optional syncDir prop (readable, sync-enabled directory), updated version.
components/zoho_crm/package.json Incremented package version from 0.6.0 to 0.6.1.

Poem

In a burrow of code, a syncDir appears,
To keep all your files across hops and years.
Attachments now travel with less fear of loss,
While versions hop forward—no carrots, no dross!
With folders that sync and persistence anew,
This bunny’s delighted to bring it to you.
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

components/zoho_crm/actions/upload-attachment/upload-attachment.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:202:49)

components/zoho_crm/actions/download-attachment/download-attachment.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:202:49)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d001247 and 2732b0e.

📒 Files selected for processing (3)
  • components/zoho_crm/actions/download-attachment/download-attachment.mjs (3 hunks)
  • components/zoho_crm/actions/upload-attachment/upload-attachment.mjs (2 hunks)
  • components/zoho_crm/package.json (1 hunks)
🔇 Additional comments (6)
components/zoho_crm/package.json (1)

3-3: LGTM! Version increment is appropriate.

The minor version bump from 0.6.0 to 0.6.1 correctly reflects the addition of new optional functionality without breaking existing implementations.

components/zoho_crm/actions/upload-attachment/upload-attachment.mjs (2)

9-9: LGTM! Version increment follows semantic versioning.

The patch version bump from 0.1.0 to 0.1.1 is appropriate for adding an optional feature.

33-41: Well-implemented syncDir configuration for file reading.

The syncDir property is correctly configured with:

  • accessMode: "read" - appropriate for an upload action that consumes files
  • sync: true - enables the file stash synchronization
  • optional: true - maintains backward compatibility
  • Clear documentation explaining the functionality
components/zoho_crm/actions/download-attachment/download-attachment.mjs (3)

8-8: LGTM! Version increment follows semantic versioning.

The patch version bump from 0.2.1 to 0.2.2 is appropriate for adding an optional feature.

37-46: Well-implemented syncDir configuration for file writing.

The syncDir property is correctly configured with:

  • accessMode: "write" - appropriate for a download action that creates files
  • sync: true - enables the file stash synchronization
  • optional: true - maintains backward compatibility
  • Comprehensive documentation explaining the functionality and legacy support

56-56: Smart use of environment variable with fallback.

The file path logic correctly uses STASH_DIR environment variable when available, falling back to /tmp for backward compatibility. This allows the platform to control where files are saved for syncing while maintaining existing functionality.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

js07 added 2 commits June 24, 2025 19:39
@js07
make dir prop optional in Download Attachment
4a664e6 
Since file content is returned from the `run` method of the action, the
action can be used in Connect without persisting the file for later use.
@js07
Merge branch 'master' into configure-filesync-for-zohocrm
2732b0e
@js07 js07 marked this pull request as ready for review June 26, 2025 22:25
@js07 js07 moved this to Ready for PR Review in Component (Source and Action) Backlog Jun 26, 2025
michelle0927
michelle0927 approved these changes Jun 27, 2025
View reviewed changes
Copy link
Collaborator

@michelle0927 michelle0927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michelle0927 michelle0927 moved this from Ready for PR Review to Ready for QA in Component (Source and Action) Backlog Jun 27, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Jun 28, 2025
@vunguyenhung vunguyenhung moved this from In QA to Ready for Release in Component (Source and Action) Backlog Jun 28, 2025
@vunguyenhung
Copy link
Collaborator

vunguyenhung commented Jun 28, 2025

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/Configure-file-stash-sync-for-Zoho-CRM-components-21fbf548bb5e81a39e39df0b920d644f

@js07 js07 merged commit 724480c into master Jun 30, 2025
11 checks passed
@js07 js07 deleted the configure-filesync-for-zohocrm branch June 30, 2025 16:07
@github-project-automation github-project-automation bot moved this from Ready for Release to Done in Component (Source and Action) Backlog Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michelle0927 michelle0927 michelle0927 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Component (Source and Action) Backlog
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@js07 @vunguyenhung @michelle0927